refactor(store-contracts): Extract neutral store contracts leaf#1160
Merged
refactor(store-contracts): Extract neutral store contracts leaf#1160
Conversation
Move the neutral store contracts into :foundation-store-contracts while keeping the network.crypta.store package names intact. Genericize GetPubkey to remove the contracts leaf's dependency on DSAPublicKey, update the affected production and test call sites, and wire the new leaf into Gradle selective ownership metadata.
Update the README and the build, architecture, and packaging skills to reflect the current extracted leaf set. Document foundation-support and foundation-store-contracts, clarify config leaf exports, and refresh the quick-check guidance for the partial multi-project build.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 832b124ac2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
foundation-store-contracts/src/main/java/network/crypta/store/GetPubkey.java
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:foundation-store-contractsleaf and moveBlockMetadata,GetPubkey, andStorableBlockinto it while keeping thenetwork.crypta.storepackageGetPubkeyand update the affected production and test call sites so the neutral contracts leaf no longer depends onDSAPublicKeyHow to test
./gradlew verifySelectiveLeafOwnershipMetadata compileJava compileTestJava./gradlew testCommits
f218ec7d47 refactor(store-contracts): Extract neutral store contracts leaf832b124ac2 docs(modules): Refresh extracted leaf documentation